Fix incorrect query results for array type column in Bigquery with bigquery.arrow-serialization.enabled enabled
#23982
+34
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 24a6da9.
ebyhr
reviewed
Oct 30, 2024
plugin/trino-bigquery/src/test/java/io/trino/plugin/bigquery/TestBigQueryAvroConnectorTest.java
Outdated
Show resolved
Hide resolved
plugin/trino-bigquery/src/test/java/io/trino/plugin/bigquery/BaseBigQueryConnectorTest.java
Outdated
Show resolved
Hide resolved
mayankvadariya
force-pushed
the
mayank/fix-bigquery-array-query
branch
2 times, most recently
from
59b6959 to
19c9264
Compare
|
also add a release note |
ebyhr
approved these changes
Oct 30, 2024
|
/test-with-secrets sha=19c92646c866365a749b7e4e72c8fc669ca69dda |
|
The CI workflow run with tests that require additional secrets finished as failure: https://github.com/trinodb/trino/actions/runs/11602476723 |
ebyhr
reviewed
Oct 30, 2024
plugin/trino-bigquery/src/test/java/io/trino/plugin/bigquery/BaseBigQueryTypeMapping.java
Show resolved
Hide resolved
mayankvadariya
force-pushed
the
mayank/fix-bigquery-array-query
branch
from
19c9264 to
4cfb82d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
[Bigquery] Fix array data type column returning incorrect results when
bigquery.arrow-serialization.enabledis enabled.Diagnosis:
((ListVector) vector).getDataVector();seem to return data for whole column.trino/plugin/trino-bigquery/src/main/java/io/trino/plugin/bigquery/BigQueryArrowToPageConverter.java
Line 247 in 0a72a74
Additional context and related issues
Release notes
( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
(x) Release notes are required, with the following suggested text: